Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expiration (MM/YY) cannot be translated #536

Open
antedrnasin opened this issue Apr 12, 2021 · 1 comment
Open

Expiration (MM/YY) cannot be translated #536

antedrnasin opened this issue Apr 12, 2021 · 1 comment
Labels
i18n Internationalization and localization issues Needs Reporter Feedabck Issues awaiting for OP feedback

Comments

@antedrnasin
Copy link

antedrnasin commented Apr 12, 2021

UPDATE: I got it to work. the only problem is the "Expiration (MM/YY)" text. It just doesn't work. My guess is that somewhere down the line, during parsing, the SLASH inside that variable is causing it not to be overridden.

@antedrnasin antedrnasin changed the title Overriding translations Expiration (MM/YY) cannot be translated Apr 15, 2021
@unfulvio-godaddy
Copy link
Member

Hey @antedrnasin is this still an issue? If you are referring to this line in

'label' => __( 'Expiration (MM/YY)', 'woocommerce-plugin-framework' ),
it is wrapped in a WP gettext function with the woocommerce-plugin-framework and should be translatable like any other WP string in such context -- I notice however the placeholder attribute is not equally translated: is that the issue you are referring to?

@unfulvio-godaddy unfulvio-godaddy added i18n Internationalization and localization issues Needs Reporter Feedabck Issues awaiting for OP feedback labels Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Internationalization and localization issues Needs Reporter Feedabck Issues awaiting for OP feedback
Projects
None yet
Development

No branches or pull requests

2 participants