Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change payment notification listener hook name #323

Open
jdeeburke opened this issue Oct 11, 2018 · 0 comments
Open

Change payment notification listener hook name #323

jdeeburke opened this issue Oct 11, 2018 · 0 comments
Labels
Bug Raises or fixes a bug Payment Gateway Payment gateway code or issues

Comments

@jdeeburke
Copy link
Contributor

SV_WC_Payment_Gateway_Hosted automatically registers an action to listen for hosted transaction responses based on the value of get_class() -- see it here.

This has been fine in the past, but as we begin to move towards using namespaces in more plugins, this will become a problem as get_class() will result in the fully-qualified class name, including backslashes, therefore creating an action like woocommerce_api_skyverge\woocommerce\plugin_name\gateway which is pretty nasty-looking and won't work.

Instead, perhaps we should use the Gateway ID in the action rather than the class name.

@jdeeburke jdeeburke added Bug Raises or fixes a bug Payment Gateway Payment gateway code or issues labels Oct 11, 2018
@ChaseWiseman ChaseWiseman added this to the v5.4.0 milestone Feb 8, 2019
@ChaseWiseman ChaseWiseman removed this from the v5.4.0 milestone Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Raises or fixes a bug Payment Gateway Payment gateway code or issues
Projects
None yet
Development

No branches or pull requests

2 participants