Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support further resource constraints options #291

Open
gklittlejohn opened this issue Sep 12, 2024 · 1 comment
Open

Feature Request: Support further resource constraints options #291

gklittlejohn opened this issue Sep 12, 2024 · 1 comment

Comments

@gklittlejohn
Copy link

When attempting to limit resource usage via the CPUs field for a Windows container gives an error occurs when trying to create the container "body: {"message":"invalid option: Windows does not support CPUPeriod"}".

It should be possible to limit CPU resource usage for Windows containers via the --cpus, --cpu-percent and --cpu-shares flags. Ideally these would be surfaced on the agent profile configuration.

@chadlwilson
Copy link
Contributor

Are you willing to.make changes, test and submit a PR? I don't really have an environment to test within as don't have native windows hardware, only ARM VMs.

Can test more easily with the ECS plugin than this non-orchestration variant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants