Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fizz shouldn't require any columns, like id or timestamps #5

Open
markbates opened this issue Jun 30, 2018 · 2 comments
Open

Fizz shouldn't require any columns, like id or timestamps #5

markbates opened this issue Jun 30, 2018 · 2 comments
Assignees
@stanislas-m
Labels
proposal A suggestion for a change, feature, enhancement, etc s: accepted was accepted or confirmed

Comments

@markbates
Copy link
Member

Currently Fizz is enforcing an old Pop rule that id and timestamps columns are added. The enforcement of these rules should be done in gobuffalo/pop not Fizz.
@markbates markbates mentioned this issue Jun 30, 2018
Open
stanislas-m added a commit that referenced this issue Aug 9, 2018
@stanislas-m
Remove ID column enforcement
b4a74d5 
Fixes first part of #5. When using the model generator in pop this enforcement
is already done:
https://github.com/gobuffalo/pop/blob/v4.6.3/soda/cmd/generate/model.go#L121
@stanislas-m stanislas-m mentioned this issue Aug 9, 2018
Merged
stanislas-m added a commit that referenced this issue Aug 20, 2018
@stanislas-m
Remove ID column enforcement (#15)
2376bb6 
* Remove ID column enforcement

Fixes first part of #5. When using the model generator in pop this enforcement
is already done:
https://github.com/gobuffalo/pop/blob/v4.6.3/soda/cmd/generate/model.go#L121

* Remove INT_ID_COL & UUID_ID_COL

* Fix translators tests
@okdas
Copy link

okdas commented Oct 26, 2018

Just FYI this conflicts with documentation.

@stanislas-m stanislas-m self-assigned this Mar 14, 2019
@stanislas-m
Copy link
Member

Migration done in Pop development branch, and the fix tool can migrate the fizz files. So we just need to change the Readme now.

@stanislas-m stanislas-m added proposal A suggestion for a change, feature, enhancement, etc s: accepted was accepted or confirmed labels Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stanislas-m stanislas-m

Labels
proposal A suggestion for a change, feature, enhancement, etc s: accepted was accepted or confirmed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@markbates @stanislas-m @okdas