This repository has been archived by the owner on Apr 20, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, in this pull request, I did a lot of changes, but I hope that it will be approved despite of that. From redesigning the components architecture to improving the flow of loading of actions, and fixing multiple issues.
Redesign the component's architecture
ResourceDetail
nova-component intoResourceDetailView
to better express what kind of component it is.IndexActions
component intoActionButtonGroup
to transform it into a reusable component and better express what this component contains.InvisibleActions
component intoInvisibleActionsDropdown
to better express what kind of component it is.DetailActions
component and reuse theActionButtonGroup
instead of it.Improvements
detachedAction
property and pass them toActionButtonGroup
andActionSelector
orDetailActionDropdown
components. This improvement will help us to be able to usecanSee
andcanRun
after a resource was selected.Fixing issues
.reverse()
calling).selectedResources
intoActionButtonGroup
.@actionExecuted
directive.