Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Fix selected resources issue #75

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

adrianmihaila
Copy link

@adrianmihaila adrianmihaila commented Sep 7, 2022

Unfortunately, in this pull request, I did a lot of changes, but I hope that it will be approved despite of that. From redesigning the components architecture to improving the flow of loading of actions, and fixing multiple issues.

Redesign the component's architecture

Nova Detached Actions

  • Rename the ResourceDetail nova-component into ResourceDetailView to better express what kind of component it is.
  • Rename the IndexActions component into ActionButtonGroup to transform it into a reusable component and better express what this component contains.
  • Rename the InvisibleActions component into InvisibleActionsDropdown to better express what kind of component it is.
  • Delete the DetailActions component and reuse the ActionButtonGroup instead of it.

Improvements

  • Use the actions that came from the Nova parent's components, filtering them by detachedAction property and pass them to ActionButtonGroup and ActionSelector or DetailActionDropdown components. This improvement will help us to be able to use canSee and canRun after a resource was selected.
  • Show standalone detached actions without selecting a resource.

Fixing issues

  • Fix webpack mix alias issue.
  • Keep actions in the initial order(remove .reverse() calling).
  • Fix selected resource issue, passing the Nova parent's selectedResources into ActionButtonGroup.
  • Reload the listing or the detail page after the action was executed by using @actionExecuted directive.

@adrianmihaila adrianmihaila force-pushed the nova4-fix-selected-resources-issue branch 2 times, most recently from 953a312 to a7dd8e3 Compare September 14, 2022 21:24
@adrianmihaila adrianmihaila force-pushed the nova4-fix-selected-resources-issue branch from a7dd8e3 to dbe10c5 Compare September 14, 2022 22:02
@adrianmihaila adrianmihaila force-pushed the nova4-fix-selected-resources-issue branch from 7dd2f7f to a502586 Compare September 26, 2022 14:04
@chrillep
Copy link

ping @the-alichemist

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants