Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Dosen't show device activation code #5

Open
1 task done
BenjaminHoegh opened this issue May 23, 2023 · 11 comments
Open
1 task done

[BUG] Dosen't show device activation code #5

BenjaminHoegh opened this issue May 23, 2023 · 11 comments

Comments

@BenjaminHoegh
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Skærmbillede 2023-05-23 kl  19 00 01

Expected Behavior

No response

Steps To Reproduce

No response

Environment

No response

Relevant log output

No response

Anything else?

No response

@devinbaeten
Copy link

Also experiencing this in Nova 11.0

@Westindies972
Copy link

Same issue for me in Nova 11

@P-James
Copy link

P-James commented May 25, 2023

It doesn't display but it was in my clipboard.
Just paste it in when the browser tab opens

@Westindies972
Copy link

Thanks a lot, I just tried, it was in my clipboard.

@halfnibble
Copy link

OMG. So it was in my clipboard!

@devinbaeten
Copy link

devinbaeten commented Jun 29, 2023

It’s quite convenient that you put the code in our clipboard during the auth flow, but from a UX standpoint this is very bad.

Writing to the clipboard without a users knowledge could lead to loss of data and or (evidently) confusion.

Please consider making an alert that displays the code or a prompt asking to save the code to the clipboard.

@gobijan
Copy link
Owner

gobijan commented Jul 3, 2023

Feel free to open a PR an I'll review it :)

@wptechnology
Copy link

Yes same here... I have lost a lot of time to just finally found someone somewhere that says that it should be copied in the clipboard...
Men, if you can't show an alert window, please write something in the extension console at least that says "Device code copied in clipboard... Just have to past it in the GitHub Page" !!!

@gobijan
Copy link
Owner

gobijan commented Aug 14, 2023

This was just a quick exploration to see if it was feasible. At the moment I do not plan on allocating time to this extension.

Feel free to create a PR with documentation fixes and the alert and log improvements. This shouldn't be too hard. Give it a try :)

@TheBoatyMcBoatFace
Copy link
Contributor

Solution documented in #8

@TheBoatyMcBoatFace
Copy link
Contributor

BenjaminHoegh

Have you tried it with the new docs? I hate to say _it worked for me, but when I ran through the nvim steps, things were groovy.

Here are the docs I'm taking about

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants