Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: ExplodedSemiDonut3DGraph #55

Open
erikjandelange opened this issue Nov 22, 2021 · 5 comments
Open

Feature: ExplodedSemiDonut3DGraph #55

erikjandelange opened this issue Nov 22, 2021 · 5 comments
Assignees

Comments

@erikjandelange
Copy link

First: AWESOME library! I really like the look of it and the flexability it brings.

I'm using all kind of 3D graphs but i'm missing the 3D version of the SemiDonutGraph.
Is it possible to add this to the library?

For now i'm using the ExplodedPie3DGraph with startangle of 180 and end-angle of 360, but the SemiDonut in 3D would be looking a lot nicer
Screenshot 2021-11-22 at 13 43 08

Cheers!
Erik-Jan

@goat1000 goat1000 self-assigned this Nov 23, 2021
@goat1000
Copy link
Owner

3D donut graphs were already on my to-do list, but you are the first to ask about them. I'll see if I can get them done in the next week or two.

@erikjandelange
Copy link
Author

That would be awesome. Thanks for the quick reply.

@goat1000
Copy link
Owner

goat1000 commented Dec 2, 2021

I've added the 3D donut graph and semi/exploded variants in 705d55e - let me know if you spot any problems with them.

The new types are Donut3DGraph, SemiDonut3DGraph, ExplodedDonut3DGraph and ExplodedSemiDonut3DGraph. I've also added ExplodedSemiDonutGraph because it was missing before.

@erikjandelange
Copy link
Author

Awesome! They work great!

Here by the examples (i've created):

ExplodedSemiDonutGraph
ExplodedSemiDonutGraph

ExplodedSemiDonut3DGraph
ExplodedSemiDonut3DGraph

ExplodedDonut3DGraph
ExplodedDonut3DGraph

SemiDonut3DGraph
SemiDonut3DGraph

Donut3DGraph
Donut3DGraph

The only thing I experienced is that I couldn't download via composer. It had to be through a zip or a git clone.

When i used composer the new classes where missing. I've cleared my composer cache. Remove the package from composer and re-added it again. Nothing worked.
But when i cloned the repository it work immediatly

Again, thanks for the great (and fast) work!

@goat1000
Copy link
Owner

goat1000 commented Dec 6, 2021

Thanks for the response - it looks like those graphs are working properly.

I expect the composer problem is because your require section is not asking for the development version of SVGGraph. Without that it will only installed tagged versions (which makes sense - the development version might not be very stable).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants