Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add errors for missing error codes #54

Open
nemith opened this issue Mar 26, 2021 · 0 comments
Open

Add errors for missing error codes #54

nemith opened this issue Mar 26, 2021 · 0 comments
Labels
easy Good for newcomers enhancement New feature or request
Milestone

Comments

@nemith
Copy link

nemith commented Mar 26, 2021

There are additional error codes added to the server that we don't always handle ok. For example -6 is missing for UnimplementedException. See #49.

We just need to go through https://github.com/apache/zookeeper/blob/190a227aa9d4655ebfe6ba9f5c2da426da8c5d98/zookeeper-server/src/main/java/org/apache/zookeeper/KeeperException.java#L229 and make sure we have coverage. For v1 these need to be just regular errors but in v2 we should look at doing a ZKPathError or something like that that could add contextual information to the error (#32)

@nemith nemith added enhancement New feature or request easy Good for newcomers labels Mar 26, 2021
@jeffbean jeffbean added this to the v2 milestone Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy Good for newcomers enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants