diff --git a/scm/github/github.go b/scm/github/github.go index a42c72487..00f0ef96f 100644 --- a/scm/github/github.go +++ b/scm/github/github.go @@ -144,7 +144,6 @@ func New(opts ...ClientOpt) (*client, error) { return nil, fmt.Errorf("failed to parse RSA private key: %w", err) } - fmt.Println("using custom round tripper") transport := NewAppsTransportFromPrivateKey(http.DefaultTransport, c.config.AppID, privateKey) transport.BaseURL = c.config.API @@ -274,7 +273,6 @@ func (c *client) newGithubAppInstallationRepoToken(ctx context.Context, r *api.R return t.GetToken(), nil } - // todo: pagination? // list all installations (a.k.a. orgs) where the GitHub App is installed installations, _, err := client.Apps.ListInstallations(context.Background(), &github.ListOptions{}) if err != nil { diff --git a/scm/github/repo.go b/scm/github/repo.go index d4a16acf2..246d34430 100644 --- a/scm/github/repo.go +++ b/scm/github/repo.go @@ -802,7 +802,6 @@ func (c *client) GetNetrcPassword(ctx context.Context, r *api.Repo, u *api.User, logrus.Infof("getting netrc password") // the app might not be installed - // todo: pass in THIS repo to only get access to that repo // https://docs.github.com/en/apps/creating-github-apps/authenticating-with-a-github-app/authenticating-as-a-github-app-installation // maybe take an optional list of repos and permission set that is driven by yaml t, err := c.newGithubAppInstallationRepoToken(ctx, r, repositories, map[string]string{})