Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert double buffering. #1435

Open
methane opened this issue May 24, 2023 · 1 comment · May be fixed by #1643
Open

Revert double buffering. #1435

methane opened this issue May 24, 2023 · 1 comment · May be fixed by #1643
Labels
database/sql issue

Comments

@methane
Copy link
Member

methane commented May 24, 2023 •
edited
Loading

Go 1.21 will fix race between Context cancel and sql.RawBytes.
See golang/go#60304

It will be backported to Go 1.19.

We had implemented double buffering (#943) to workaround it. It increase memory usage and complexity.

After Go 1.19.10 containing this fix is released, let's remove the double buffering in go-mysql-driver v1.8.0.

P.S. We need to drop Go 1.18 support. It would violate our Go version support policy. But Go 1.21 will be released in August, before we release v1.8.0.
@methane
Copy link
Member Author

methane commented Oct 9, 2023

It is not backported into Go 1.19 and 1.20.
So we need to wait that we drop Go 1.20 support.

@methane methane linked a pull request Nov 23, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
database/sql issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

stop double-buffering methane/mysql
1 participant
@methane