Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How does it work ? #4

Open
grzesuav opened this issue Mar 9, 2024 · 4 comments
Open

How does it work ? #4

grzesuav opened this issue Mar 9, 2024 · 4 comments

Comments

@grzesuav
Copy link

grzesuav commented Mar 9, 2024

Hi, let's assume I have a helm manifest, which I want to update & package - by update I mean somewhere docker imge version is set and I need to update it on release, and later push to helm repository.

How would it work ?

@grzesuav
Copy link
Author

Looking at the code, its only job is to update version in Chary.yaml,

@christophwitzko
Copy link
Member

Hi @grzesuav, this plugin was initially built by @SISheogorath. They might be able to help you with any further questions.

@grzesuav
Copy link
Author

Got it ! My biggest question is - does it actually commit the changed file or this is ephemeral change done just during the releasing process ?

@SISheogorath
Copy link
Member

Like all other plugins of go-semantic-release, this doesn't commit anything.

If it would, you could end up with detached commits that are only referenced as tags in your git repository, I don't think that's intended.

I also only realised this after writing this plugin, which drastically limits the usefulness. But there is room for a commit plugin, which could resolve this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants