-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement comment-check in workflows. #3426
base: main
Are you sure you want to change the base?
Conversation
It seems to be effective. Does he check the entire code every time? Also, can we directly comment on the issue in the PR, otherwise we still need to check the action details |
This Check only run when pull request into I think it is feasible to have the bot comment on the error details. I will add this part in a later commit. |
What I mean is, can we only check the code for PR changes? Instead of scanning the full code |
I tried to implement checking only the diff, and it works. However, I think this approach ignores existing errors and doesn’t handle them properly. Since this CI process only scans text and isn’t time-consuming, I recommend scanning the entire repo. If you wish, I will implement a version that checks only the diff. |
feat: add bot output comment when failed.
I’ve updated the version to only check the diff files in the PR and commented out the whole repo check version. I also added a bot comment when the check fails. If you think it looks good, I’ll push the final version. |
I try to use I need to help provide the Bot PAT having issues:write and pull-requests: write. Like
|
Understood, let me add a key |
…and update permissions
Sorry, my bad. We just need to use the ci_bot_token from the But use If any errors after this PR is merged, please tell me know and I’ll fix it. |
同时也辛苦包子哥哥这几天的跟进和回复 感谢! |
At the same time, thank you very much for Brother Baozi’s follow-up and reply these days! |
@shenqidebaozi @Windfarer @daemon365 Hello, can your have a check this PR? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3426 +/- ##
==========================================
- Coverage 84.12% 81.69% -2.43%
==========================================
Files 89 92 +3
Lines 4182 4327 +145
==========================================
+ Hits 3518 3535 +17
- Misses 471 601 +130
+ Partials 193 191 -2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Description (what this PR does / why we need it):
implement comment check in workflows when commit PR have Chinese. If check files have a Chinese, CI will failed.
Which issue(s) this PR fixes (resolves / be part of):
Fixes #3422
Other special notes for the reviewers:
Need remove test Chinese comments when PR is merged.