-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve clickhouse table creation #154
base: master
Are you sure you want to change the base?
Conversation
854d70e
to
c2d650a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, but I'm only wondering what exactly you mean with "will be almost always 0"?
Co-authored-by: Thomas Casteleyn <[email protected]>
E.g., when we have a column with values |
I still haven't tested the performance of this changes. Is a bit stuck on go-graphite/graphite-clickhouse-tldr#6 to have the tags and all other stuff in the DB |
Thanks to inform this, I was going to apply this to PROD, but will wait. It is doing fine on a small DEV server:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use TTL based on Date
column to align with graphite data table? That way it also won't cause issues when Version
isn't representing a timestamp anymore..
Co-authored-by: Thomas Casteleyn <[email protected]>
I need as well to test all the tables for performance before merging it