Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code readability , small improvement for limit clause code #7243

Closed
danish-mehmood opened this issue Oct 17, 2024 · 1 comment
Closed

code readability , small improvement for limit clause code #7243

danish-mehmood opened this issue Oct 17, 2024 · 1 comment
Assignees
Labels

Comments

@danish-mehmood
Copy link

danish-mehmood commented Oct 17, 2024

  • I would like to suggest the following small change in clause/limit.go file regarding code readability
    the type Limit is described the following way
type Limit struct {
	Limit  *int
	Offset int
}
  • this is extremely confusing for someone reading the code the field named Limit inside of Limit type

  • can we change it to something like "MaxRows" , "LimitValue" e.t.c , that would make it very readable

  • and secondly (i am not sure about this one , open to suggestions) the following code has redundancy that it is making the
    same checks twice , can't we improve this , by reducing the redundancy?

// Build build where clause
func (limit Limit) Build(builder Builder) {
	if limit.Limit != nil && *limit.Limit >= 0 {
		builder.WriteString("LIMIT ")
		builder.WriteString(strconv.Itoa(*limit.Limit))
	}
	if limit.Offset > 0 {
		if limit.Limit != nil && *limit.Limit >= 0 {
			builder.WriteByte(' ')
		}
		builder.WriteString("OFFSET ")
		builder.WriteString(strconv.Itoa(limit.Offset))
	}
}
@github-actions github-actions bot added the type:missing reproduction steps missing reproduction steps label Oct 17, 2024
Copy link

The issue has been automatically marked as stale as it missing playground pull request link, which is important to help others understand your issue effectively and make sure the issue hasn't been fixed on latest master, checkout https://github.com/go-gorm/playground for details. it will be closed in 30 days if no further activity occurs. if you are asking question, please use the Question template, most likely your question already answered https://github.com/go-gorm/gorm/issues or described in the document https://gorm.ioSearch Before Asking

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants