Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Admin users cannot see private forks #33368

Open
koalajoe23 opened this issue Jan 23, 2025 · 0 comments · May be fixed by #33401
Open

Regression: Admin users cannot see private forks #33368

koalajoe23 opened this issue Jan 23, 2025 · 0 comments · May be fixed by #33401
Labels
Milestone

Comments

@koalajoe23
Copy link

koalajoe23 commented Jan 23, 2025

Description

After the merge of #32528 forks are only visible via UI and API if the authenticated user has explicit permission to view the forked repository.

I maintain a gitea instance where we have automation in place to enumerate repo forks via API. Those are private forks and we cannot and don't want to explicitly manage permissions, so for API querying an account with admin permissions is used. Before the aforementioned PR this worked great, but now no forks are returned by the getForks API.

IMO, when an account with admin permissions is generally not bound to permission checks, e.g. when viewing and interacting with repos, this should also apply to enumerating private forks.

Gitea Version

1.23.1

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

Debian Bookworm

How are you running Gitea?

Release binary (amd64) downloaded from Github

Database

PostgreSQL

@lunny lunny added this to the 1.23.2 milestone Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants