Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formulate more clearly in the readme the system-calls issue #24

Open
gnzlbg opened this issue Feb 1, 2018 · 1 comment
Open

Formulate more clearly in the readme the system-calls issue #24

gnzlbg opened this issue Feb 1, 2018 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@gnzlbg
Copy link
Owner

gnzlbg commented Feb 1, 2018

The readme currently states as Drawback:

  • global allocator bypass: SliceDeque bypasses Rust's global allocator / it is its own memory allocator, talking directly to the OS. That is, allocating and growing SliceDeques always involve system calls, while a VecDeque backed-up by a global allocator might receive memory owned by the allocator without any system calls at all.

Until, as @bill-myers mentioned in #19 , the library starts caching previously-freed allocations for future reuse, this is going to remain a major drawback of the library and users should be aware of it.

This drawback should be explaining more clearly to avoid any misunderstandings.

@gnzlbg gnzlbg added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Feb 1, 2018
@gnzlbg
Copy link
Owner Author

gnzlbg commented Feb 1, 2018

The reddit post explains the drawbacks a bit differently, maybe the explanations there are more clear?

https://www.reddit.com/r/rust/comments/7u45jv/slicedeque_a_doubleended_queue_that_derefs_into_a/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant