Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally Override gnorm.toml ConnStr via cli flag #51

Open
daniel-reed opened this issue Oct 15, 2017 · 3 comments
Open

Optionally Override gnorm.toml ConnStr via cli flag #51

daniel-reed opened this issue Oct 15, 2017 · 3 comments

Comments

@daniel-reed
Copy link
Member

This would allow using db credentials without putting them in a config file.

@natefinch
Copy link
Member

FYI, you can use environment variables transparently in gnorm.tom configuration values, so a ConnStr that has -p=$DB_PASSWORD will do the right thing.

However, I agree that being able to specify the connection string on the CLI is probably also good.

@daniel-reed
Copy link
Member Author

Thanks for the tip on the environment variables. I'll go that route for now. I'll probably have a pull request for the cli flag next weekend if you agree it has value.

@natefinch
Copy link
Member

definitely think the cli flag would be good, and would love a PR. Maybe -d and --database? unfortunately, -c is already taken. if you could add it to preview and gen, that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants