Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Fix race conditions and run tests with -race flag #2097

Open
ajnavarro opened this issue May 14, 2024 · 2 comments
Open

CI: Fix race conditions and run tests with -race flag #2097

ajnavarro opened this issue May 14, 2024 · 2 comments
Assignees
@mvertes
Labels
⭐️ could have ⭐️ Optional work needed to complete a project
Milestone
🏗4️⃣ test4.gno.la...

Comments

@ajnavarro
Copy link
Contributor

Description

-race flag is currently deactivated on our CI due to some race conditions on the code. Fix these race conditions and set the flag for all tests.
@moul moul added 🗺️good first issue🗺️ Ideal for newcomer contributors help wanted labels Jul 14, 2024
@DIGIX666 DIGIX666 mentioned this issue Aug 6, 2024
Closed
@DIGIX666
Copy link
Contributor

DIGIX666 commented Aug 6, 2024

Hi @ajnavarro
I've started trying to solve this issues
When do you have a time, can you check my Draft PR to see if I'm going in the right direction please 🙏🏼

@leohhhn leohhhn mentioned this issue Aug 21, 2024
Open
@DIGIX666 DIGIX666 mentioned this issue Sep 4, 2024
Open
@zivkovicmilos zivkovicmilos added ⭐️ could have ⭐️ Optional work needed to complete a project help wanted Want to contribute? We recommend these issues. labels Sep 11, 2024
@mvertes mvertes removed 🗺️good first issue🗺️ Ideal for newcomer contributors help wanted help wanted Want to contribute? We recommend these issues. labels Sep 27, 2024
@moul moul mentioned this issue Sep 27, 2024
Open
@moul
Copy link
Member

moul commented Sep 27, 2024

Cross-linking #2826 (comment)

Sounds reasonable. Does anyone have an estimation of the feasibility and difficulty of removing all the race conditions?

@mvertes mvertes self-assigned this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mvertes mvertes

Labels
⭐️ could have ⭐️ Optional work needed to complete a project
Projects
🚀 main.gno.land launch 🚀
Status: TODO
🧙‍♂️gno.land core team
Status: Backlog
Milestone
🏗4️⃣ test4.gno.land [POST LAUNCH]
Development

No branches or pull requests
6 participants
@moul @ajnavarro @mvertes @Kouteki @zivkovicmilos @DIGIX666