Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement when forking the repo #3

Open
Turbots opened this issue Aug 22, 2022 · 2 comments
Open

Improvement when forking the repo #3

Turbots opened this issue Aug 22, 2022 · 2 comments

Comments

@Turbots
Copy link

Turbots commented Aug 22, 2022

Hello,

I've just forked your repository and might want to make some improvements/updates here and there, but the way the workload.yaml files have been setup, it means we would have to make the git references more generic, otherwise it's impossible to make proper pull requests. How could we do this? kustomize? YTT? regular templating or scripting?

@gm2552
Copy link
Owner

gm2552 commented Aug 22, 2022

it means we would have to make the git references more generic

Are you speaking of the individual workload.yaml files in each source code directory, or the templated workloads.yaml. If the previous, then this issue exists in pretty much every accelerator generated project. I'm hearing there may be an enhancement at a later time to provide a GitRepo in the accelerator that would automatically create a GitRepo. If the becomes a reality, the plan is update the repo reference in the workload.yaml files to this new repo.

@Turbots
Copy link
Author

Turbots commented Aug 23, 2022

Agreed, I heard that this is on the roadmap for TAP 1.3 iirc, so we'll wait for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants