Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3D scatter viewer broken #449

Closed
astrofrog opened this issue May 17, 2024 · 4 comments · Fixed by #456
Closed

3D scatter viewer broken #449

astrofrog opened this issue May 17, 2024 · 4 comments · Fixed by #456
Labels
bug Something isn't working 🔥 viewer-3d-scatter

Comments

@astrofrog
Copy link
Member

The 3D scatter viewer is no longer showing any points for me, and also shows an additional panel between the visualization and the regular glue viewer and layer options:

image

@maartenbreddels - before I dig too far into this, are you aware of any changes in ipyvolume recently that might have caused this?

@astrofrog astrofrog added bug Something isn't working 🔥 viewer-3d-scatter labels May 17, 2024
@astrofrog
Copy link
Member Author

To hide the side panel we need widgetti/ipyvolume#442

@maartenbreddels
Copy link
Collaborator

I think we shouldn't see the side panel at all, we should just take a ipyvolume figure.

Not sure why the scatter does not work. https://py.cafe/maartenbreddels/ipyvolume-3d-vector-field seems to work fine.

@Carifio24
Copy link
Member

@maartenbreddels It must be something in how the scatter is wired up to the glue viewer (though I haven't really had time to investigate), as Azmé and I have made ipyvolume scatters that work, but then the same data won't display in glue.

@Carifio24
Copy link
Member

@astrofrog @maartenbreddels I figured out the basic issue here . It looks like trying to make a plot where one of the x/y/z components has an underlying numpy array whose data type isn't a float won't work. And it seems to fail in a way that breaks updating the scatter widget, as changing the offending component to something that's floats doesn't fix things

As an example see this gist. The original W5 data won't show, but if I create a new data object with non-float components removed, it renders fine. I'm not sure whether this is an ipyvolume issue (some sort of bad serialization?) or whether we need to do some astype-ing in the layer artist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🔥 viewer-3d-scatter
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants