feat: mouse move events exposed #37
Conversation
|
This looks very promising, thanks! Does it work the same for mouse clicks (left, right, etc)? For example: I want to extract the X, Y when I left-click on a star -- how do I do that? |
|
good question, added: |
|
Maybe if you delete this line, it will proceed further... Line 2 in 4eea0ad |
|
Ops, sorry... That wasn't it. Maybe this one: Line 139 in 4eea0ad 😬 |
maartenbreddels
force-pushed
the
feat_mouse_move_events
branch
from
d26e692 to
56b8a23
Compare
|
trying |
maartenbreddels
force-pushed
the
feat_mouse_move_events
branch
from
56b8a23 to
5c500db
Compare
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
==========================================
- Coverage 66.66% 65.88% -0.79%
==========================================
Files 5 5
Lines 84 85 +1
==========================================
Hits 56 56
- Misses 28 29 +1
Continue to review full report at Codecov.
|
|
Nice, got some green now! |
|
Yes, do you want to try it out first? |
I could but not till next week. Don't let me block this from merging. |
|
I tried this out on Friday and while no errors were thrown, the |
|
Did you do this on lab or notebook? and did you compare to a release or master? |
|
I guess I should include enough information to actually be useful, eh? I just checked and I have the same problem on the master with that example notebook, so it's not this PR. I'm running via Some relevant installed versions: bqplot 0.12.21 |
|
Not working for me either (in
Some version info; will be happy to provide more if I didn't give you enough info: |
|
Just for completeness, if you meant if I tried with both stable and dev
|
|
So, I got the mouse event to work but not using your
|
you probably want to add the conda-forge channel |
|
I tried reproducing the issue of not showing the image, but i could not, I have done: and that gives me a working notebook where I see the image, could someone confirm this? |
|
@maartenbreddels , can you please do a |
|
|
This worked for me after following your instructions @maartenbreddels (I think specifically doing |
|
It is a bit concerning that this doesn't work with some stuff from default channel... A lot of scientists just install the Anaconda thingy with default channel. But perhaps out of scope here. |
Note that nodejs is only needed when building from original source, the source tarball and wheel do not require nodejs. |
|
Still doesn't work for me even when I followed instructions at #37 (comment) ... This is my |
|
Did ImageGL ever work for you, and could you list the steps you have performed? And did you try to create a new env? |
|
To clarify: I see the axis but image doesn't show.
Not sure. How do I check?
I followed your instruction as much as possible. |
Install the released bqplot-image-gl (from pypi) |
|
I mean, is there something you want me to run to make sure, like certain notebook? |
|
You can try to run the notebook in this PR, or the contour notebook with the released bqplot-image-gl to see what does and does not work. |
|
Okay, with |
|
Yeah, okay. This works on Windows machine, but not the Linux one. I'll open a new issue (#38). |
|
This makes me think though... Does STScI have a need to deploy this on Linux machines? Or we are just going to assume all users going to be using OSX or Windows? |
|
There should not be a general Linux issue, if webgl works (you could try
some webgl demos to check this) ImageGL should also work. Otherwise it's a
bug.
(from mobile phone)
…On Tue, Feb 9, 2021, 21:39 P. L. Lim ***@***.***> wrote:
This makes me think though... Does STScI have a need to deploy this on
Linux machines? Or we are just going to assume all users going to be using
OSX or Windows?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#37 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANPEPO3MB6KJMCTHDURP2LS6GMPXANCNFSM4XEZI4OQ>
.
|
|
webgl is indeed complaining on Linux machine. I'll contact IT and get back to you. (Solved: See #38) |
maartenbreddels
force-pushed
the
feat_mouse_move_events
branch
from
f8c1620 to
579fd98
Compare
|
Thanks for all the feedback, any problems can be addressed in separate issues, I think this is good to go. |
|
Thanks! Any plans to do a release with this feature or are you waiting for something else? |
|
Yes, waiting for #35 (needs help from @astrofrog) and then we can do a release. |
This allows for capturing mouse events, with a demo that shows an image pixel coordinate and its value.
