-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #373: Import EXT-X-CUE-OUT and EXT-X-CUE-OUT-CONT handling #374
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -257,6 +257,14 @@ def test_segment_cue_out_cont_alt(): | |
assert segments[3].scte35_duration == "120.0" | ||
|
||
|
||
def test_segment_cue_out_cont_mediaconvert(): | ||
obj = m3u8.M3U8(playlists.CUE_OUT_MEDIACONVERT_PLAYLIST) | ||
segments = obj.segments | ||
|
||
assert segments[2].scte35_elapsedtime == "10" | ||
assert segments[2].scte35_duration == "4" | ||
|
||
|
||
def test_segment_envivio_scte35_attribute(): | ||
obj = m3u8.M3U8(playlists.CUE_OUT_ENVIVIO_PLAYLIST) | ||
segments = obj.segments | ||
|
@@ -273,7 +281,7 @@ def test_segment_envivio_scte35_attribute(): | |
def test_segment_unknown_scte35_attribute(): | ||
obj = m3u8.M3U8(playlists.CUE_OUT_INVALID_PLAYLIST) | ||
assert obj.segments[0].scte35 is None | ||
assert obj.segments[0].scte35_duration is None | ||
assert obj.segments[0].scte35_duration == "INVALID" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We now no longer assume a particular format for duration, so weird fraction stuff can flow through. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's great! Thank you |
||
|
||
|
||
def test_segment_cue_out_no_duration(): | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change affects all tags - if there's some parameter without a
key=value
pair, it will get stuck into the empty string key.