Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With "Show boosts in public timelines" enabled, boosts are not grouped #2481

Open
horaceyoung opened this issue Nov 22, 2023 · 3 comments
Open
Labels

Comments

@horaceyoung
Copy link

Steps to reproduce the problem

  1. Enable "Show boosts in public timelines".
  2. Multiple recent boosts of the same post are not grouped.
    IMG_4876
    ...

Expected behaviour

Recent boosts are grouped

Actual behaviour

Recent boosts are not grouped

Detailed description

Hi devs! "Show boosts in public timelines" is an interesting option but users' recent boosts of the same post are not grouped which affects timeline views. Boosts of a very recent post is also not hidden (The same post appearing more than one time consecutively). I'm wondering if it's a bug or expected. Thx!

Mastodon instance

m.otter.homes

Mastodon version

v4.2.0+glitch

Browser name and version

Firefox

Operating system

Windows

Technical details

No response

@Plastikmensch
Copy link

This is because aggregating boosts is handled by feed_manager.rb which manages home, list and direct timelines, while public feeds are managed by public_feed.rb.
These work very differently and without a major rewrite, replicating the aggregation logic isn't really feasible.

@horaceyoung
Copy link
Author

This is because aggregating boosts is handled by feed_manager.rb which manages home, list and direct timelines, while public feeds are managed by public_feed.rb. These work very differently and without a major rewrite, replicating the aggregation logic isn't really feasible.

Thanks for your reply! Although without adequate grouping logic to reduce duplicate posts, "Show boosts in public timelines" can barely be viable as an option. Thanks for your info anyway!

@sneakers-the-rat
Copy link

I think I got this to work - the "only show a boost every 40 posts" works well for the home feeds, but really what ppl want is to just not see the same boost a bunch of times, so only showing the most recent boost is a decent way to do it. Not that dramatic of a rewrite :). I'm a noob at rails and sql so obvi feedback appreciated if there's a better way of doing this.

NeuromatchAcademy#36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants