Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle_exit called with missing starter causes a crash #67

Open
tomalexhughes opened this issue Jul 23, 2024 · 3 comments
Open

handle_exit called with missing starter causes a crash #67

tomalexhughes opened this issue Jul 23, 2024 · 3 comments

Comments

@tomalexhughes
Copy link

tomalexhughes commented Jul 23, 2024

Creating an issue for this problem discussed in the Discord.

It's possible for the handle_exit function in the supervisor module to be called with state that is missing the starter.exec function.

This causes the following error due to this let assert

Runtime terminating during boot ({#{function=><<"handle_exit">>,line=>303,message=><<"Assertion pattern match failed">>,module=><<"gleam/otp/supervisor">>,value=>none,gleam_error=>let_assert},[{'gleam@otp@supervisor',handle_exit,2,[{file,"/[....]/build/dev/erlang/gleam_otp/_gleam_artefacts/gleam@[email protected]"},{line,235}]},{'gleam@otp@actor',loop,1,[{file,"/[....]/build/dev/erlang/gleam_otp/_gleam_artefacts/gleam@[email protected]"},{line,150}]}]})

Unfortunately I do not have a way to reproduce at the moment and I'm unsure as to the exact details that cause the none value.

@lpil
Copy link
Member

lpil commented Jul 25, 2024

Thank you.

@ghivert
Copy link

ghivert commented Aug 3, 2024

FYI, I have a regular error on Gloogle due to this error, because I'm exiting normally some children. That triggers server to restart. It's not a big deal at the moment, but it's bothering enough I'd like to fix it. Are you interested in some PR @lpil ? In case you are, do you have some opinions or some hints to get started on the subject?

@lpil
Copy link
Member

lpil commented Aug 15, 2024

PRs welcome but I've not investigated this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants