Skip to content
This repository has been archived by the owner on Dec 2, 2022. It is now read-only.

embed-responsive bootstrap class not supported? #883

Open
mkpelletier opened this issue Nov 21, 2018 · 3 comments
Open

embed-responsive bootstrap class not supported? #883

mkpelletier opened this issue Nov 21, 2018 · 3 comments

Comments

@mkpelletier
Copy link
Contributor

mkpelletier commented Nov 21, 2018

Hi Gareth,

I am loving the theme as always. Essential has come such a long way since the 2.X branch. :-)

I know essential does support some bootstrap classes already, but it seems embed-responsive and embed-responsive-item (bootstrap 4 classes supported in boost) does not seem to work on the latest version of essential. Just so you have the full picture, I am trying to put scorm presentation inside an iframe so I can avoid the default ugly moodle box icon. To this end, I would normally do:

< d i v class="embed-responsive embed-responsive-16by9"> <iframe class="embed-responsive-item" src="https://fancyname.address/mod/scorm/player.php?a=1234&amp;currentorg=articulate_rise&amp;scoid=5678&amp;display=popup&amp;mode=normal"> </iframe> < / d i v >

Is there a better way to do this in Essential?

Here are my system particulars:

Moodle version: Moodle 3.5.3+ (Build: 20181113)
Essential version: 3.5.1.1 (Build: 2018051902)

Thanks again for the help!

@mkpelletier
Copy link
Contributor Author

Pardon the funny div elements. Github refused to render my codebock with a normal div tag, so I had to edit it!

@gjb2048 gjb2048 self-assigned this Nov 21, 2018
@gjb2048
Copy link
Owner

gjb2048 commented Nov 21, 2018

Hi Mathieu,

It seems that theme\boost\scss\bootstrap\utilities_embed.scss is in BS4 and not BS2.3.2. Essential is a child theme of Bootstrapbase which is B2.3.2 and hence does not have them. Therefore the solution is to convert the SCSS _embed.scss to LESS and put them it the theme.

Kind regards,

Gareth

@gjb2048
Copy link
Owner

gjb2048 commented Nov 25, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants