Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installs an ancient version of yarn by default #98

Open
jbrowning opened this issue Aug 22, 2019 · 4 comments
Open

Installs an ancient version of yarn by default #98

jbrowning opened this issue Aug 22, 2019 · 4 comments

Comments

@jbrowning
Copy link

The default config specifies an ancient version of yarn to install by default:

yarn_version=0.27.5

This should instead be unset to allow for the latest version of yarn to be installed.

@nelsonic
Copy link

On the basis that Node.js ships with npm and there is zero benefit to using Yarn on Heroku,
could the yarn_version be removed completely? 🤔

nelsonic added a commit to dwyl/heroku-buildpack-phoenix-static that referenced this issue Sep 16, 2019
nelsonic added a commit to dwyl/heroku-buildpack-phoenix-static that referenced this issue Sep 16, 2019
@jesseshieh
Copy link
Collaborator

I think removing it completely is a good idea, but we have to worry about backward compatibility. Perhaps, we can start printing a warning and then remove it 6 months later. What do you think?
Also see #113

@jbrowning
Copy link
Author

I may be misunderstanding but I strongly disagree that there is "zero benefit to using Yarn on Heroku" -- some projects use yarn to lock, others use npm to lock, and Heroku supports both.

@jesseshieh Is your proposal simply to remove the default version of yarn so that it must be specified in the buildpack settings?

@jesseshieh
Copy link
Collaborator

Sorry yes, my proposal is just to remove the default version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants