From ad3d8f434f4acbf40e7e1f9e58485e266296c7c4 Mon Sep 17 00:00:00 2001
From: kristoferlund <kristofer@fmckl.se>
Date: Wed, 2 Aug 2023 08:08:57 +0200
Subject: [PATCH 1/7] Don't stringify before copy

---
 .../frontend/src/pages/Reports/components/CopyToClipboard.tsx   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/frontend/src/pages/Reports/components/CopyToClipboard.tsx b/packages/frontend/src/pages/Reports/components/CopyToClipboard.tsx
index f7fc05858..6e0ef6349 100644
--- a/packages/frontend/src/pages/Reports/components/CopyToClipboard.tsx
+++ b/packages/frontend/src/pages/Reports/components/CopyToClipboard.tsx
@@ -12,7 +12,7 @@ const CopyToClipboard: React.FC<CopyToClipboardProps> = ({ text }) => {
   const handleCopy = (): void => {
     const copy = async (): Promise<void> => {
       try {
-        await navigator.clipboard.writeText(JSON.stringify(text));
+        await navigator.clipboard.writeText(text);
         toast.success('Copied to clipboard');
       } catch (err) {
         console.error('Failed to copy text: ', err);

From 4fc6d412fec812c0e5068878a144f937d251f2f4 Mon Sep 17 00:00:00 2001
From: kristoferlund <kristofer@fmckl.se>
Date: Wed, 2 Aug 2023 08:15:56 +0200
Subject: [PATCH 2/7] Don't parse empty result set

---
 packages/frontend/src/pages/Reports/ReportsRunPage.tsx | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/packages/frontend/src/pages/Reports/ReportsRunPage.tsx b/packages/frontend/src/pages/Reports/ReportsRunPage.tsx
index f73a97c80..930e683fa 100644
--- a/packages/frontend/src/pages/Reports/ReportsRunPage.tsx
+++ b/packages/frontend/src/pages/Reports/ReportsRunPage.tsx
@@ -48,9 +48,13 @@ const ReportsRunPage = (): JSX.Element | null => {
 
   if (!response?.rows) return <LoadScreen />;
 
-  const json = JSON.stringify(response.rows);
-  const parser = new Parser();
-  const csv = parser.parse(response.rows);
+  let json = '';
+  let csv = '';
+  if (response.rows.length > 0) {
+    json = JSON.stringify(response.rows);
+    const parser = new Parser();
+    csv = parser.parse(response.rows);
+  }
 
   return (
     <Page variant="full">

From eba17d0ef3fddfdb5881a982b44da6c8cd3eabfd Mon Sep 17 00:00:00 2001
From: kristoferlund <kristofer@fmckl.se>
Date: Wed, 2 Aug 2023 08:19:32 +0200
Subject: [PATCH 3/7] Report summary as <pre> instead of <code>

---
 .../frontend/src/pages/Reports/components/RevealMore.tsx | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/packages/frontend/src/pages/Reports/components/RevealMore.tsx b/packages/frontend/src/pages/Reports/components/RevealMore.tsx
index d7de2303a..1b3a48c8a 100644
--- a/packages/frontend/src/pages/Reports/components/RevealMore.tsx
+++ b/packages/frontend/src/pages/Reports/components/RevealMore.tsx
@@ -20,14 +20,7 @@ const RevealMore: React.FC<RevealMoreProps> = ({ content }) => {
       <div
         className={`${isExpanded ? 'h-auto' : 'max-h-[200px]'} overflow-hidden`}
       >
-        <code>
-          {rows.map((row) => (
-            <>
-              {row}
-              <br />
-            </>
-          ))}
-        </code>
+        <pre>{rows.map((row) => `${row}\n`)}</pre>
       </div>
       {rows.length > 10 && (
         <Button onClick={toggleExpand} className="mt-5">

From 73c4eaaaf09bf401bde433d7e2c90f491e382f6c Mon Sep 17 00:00:00 2001
From: kristoferlund <kristofer@fmckl.se>
Date: Wed, 2 Aug 2023 09:00:42 +0200
Subject: [PATCH 4/7] Prevent analytics page from becoming taller than screen

---
 packages/frontend/src/pages/Analytics/AnalyticsPage.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/frontend/src/pages/Analytics/AnalyticsPage.tsx b/packages/frontend/src/pages/Analytics/AnalyticsPage.tsx
index a076abfe2..e2a081f77 100644
--- a/packages/frontend/src/pages/Analytics/AnalyticsPage.tsx
+++ b/packages/frontend/src/pages/Analytics/AnalyticsPage.tsx
@@ -37,7 +37,7 @@ const Graphs = (): JSX.Element | null => {
 
   return (
     <DuckDb startDate={date1Str} endDate={date3Str}>
-      <div className="h-full gap-5 columns-1 md:columns-2 xl:columns-3">
+      <div className="gap-5 columns-1 md:columns-2 xl:columns-3">
         <TopPraise date1={date1Str} date2={date2Str} date3={date3Str} />
         <PraiseOverTime date1={date1Str} date2={date2Str} date3={date3Str} />
         <TopPraiseGivers date1={date1Str} date2={date2Str} date3={date3Str} />

From d3a3ae02a4fd1b57b12cdce5ee2b26f99c7df92d Mon Sep 17 00:00:00 2001
From: kristoferlund <kristofer@fmckl.se>
Date: Wed, 2 Aug 2023 09:00:59 +0200
Subject: [PATCH 5/7] Fix overflow issue on long usernames

---
 .../pages/Analytics/components/TopPraiseGivers.tsx    | 10 ++++++++--
 .../pages/Analytics/components/TopPraiseReceivers.tsx | 11 +++++++----
 2 files changed, 15 insertions(+), 6 deletions(-)

diff --git a/packages/frontend/src/pages/Analytics/components/TopPraiseGivers.tsx b/packages/frontend/src/pages/Analytics/components/TopPraiseGivers.tsx
index 0c6ede3f6..88b65c30d 100644
--- a/packages/frontend/src/pages/Analytics/components/TopPraiseGivers.tsx
+++ b/packages/frontend/src/pages/Analytics/components/TopPraiseGivers.tsx
@@ -70,11 +70,17 @@ const TopPraiseGivers = ({
       {
         Header: 'Username',
         accessor: 'username',
+        // eslint-disable-next-line @typescript-eslint/no-explicit-any
+        Cell: (data: any) => (
+          <div className="overflow-hidden overflow-ellipsis whitespace-nowrap">
+            {data.value ? data.value : data.row.original.useraccountname}
+          </div>
+        ),
       },
       {
         Header: 'Score',
         accessor: 'score',
-        className: 'text-right',
+        className: 'text-right w-12',
         Cell: ({ value }: { value: number }) => (
           <span className="opacity-70">
             {new Intl.NumberFormat().format(Math.round(value))}
@@ -94,7 +100,7 @@ const TopPraiseGivers = ({
   return (
     <Graph.Frame>
       <Graph.Header>Top praise givers</Graph.Header>
-      <table {...getTableProps()} className="w-full">
+      <table {...getTableProps()} className="w-full overflow-auto table-fixed">
         <tbody {...getTableBodyProps()}>
           {rows.map((row) => {
             prepareRow(row);
diff --git a/packages/frontend/src/pages/Analytics/components/TopPraiseReceivers.tsx b/packages/frontend/src/pages/Analytics/components/TopPraiseReceivers.tsx
index 997f0c34b..f88edbbe4 100644
--- a/packages/frontend/src/pages/Analytics/components/TopPraiseReceivers.tsx
+++ b/packages/frontend/src/pages/Analytics/components/TopPraiseReceivers.tsx
@@ -73,13 +73,16 @@ const TopPraiseReceivers = ({
         Header: 'Username',
         accessor: 'username',
         // eslint-disable-next-line @typescript-eslint/no-explicit-any
-        Cell: (data: any) =>
-          data.value ? data.value : data.row.original.useraccountname,
+        Cell: (data: any) => (
+          <div className="overflow-hidden overflow-ellipsis whitespace-nowrap">
+            {data.value ? data.value : data.row.original.useraccountname}
+          </div>
+        ),
       },
       {
         Header: 'Score',
         accessor: 'score',
-        className: 'text-right',
+        className: 'text-right w-12',
         Cell: ({ value }: { value: number }) => (
           <span className="opacity-70">
             {new Intl.NumberFormat().format(Math.round(value))}
@@ -99,7 +102,7 @@ const TopPraiseReceivers = ({
   return (
     <Graph.Frame>
       <Graph.Header>Top praise receivers</Graph.Header>
-      <table {...getTableProps()} className="w-full">
+      <table {...getTableProps()} className="w-full overflow-auto table-fixed">
         <tbody {...getTableBodyProps()}>
           {rows.map((row) => {
             prepareRow(row);

From 3e42c58527818110b7cf6cb9e63853f9fef66659 Mon Sep 17 00:00:00 2001
From: kristoferlund <kristofer@fmckl.se>
Date: Wed, 2 Aug 2023 09:04:46 +0200
Subject: [PATCH 6/7] Correct report url

---
 .../frontend/src/pages/Analytics/components/TopPraise.tsx     | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/packages/frontend/src/pages/Analytics/components/TopPraise.tsx b/packages/frontend/src/pages/Analytics/components/TopPraise.tsx
index b46e4769b..a2e9550ca 100644
--- a/packages/frontend/src/pages/Analytics/components/TopPraise.tsx
+++ b/packages/frontend/src/pages/Analytics/components/TopPraise.tsx
@@ -125,7 +125,7 @@ const TopPraise = ({
     <Graph.Frame className="px-0">
       <Graph.Header className="px-5">Highest scored praise</Graph.Header>
       <div className="@container">
-        <ul className="px-5 text-xs  md:px-0">
+        <ul className="px-5 text-xs md:px-0">
           {data.map((praise) => (
             <PraiseRow praise={praise} key={praise._id}>
               <Praise praise={praise} key={praise._id} bigGiverAvatar={false} />
@@ -136,7 +136,7 @@ const TopPraise = ({
       <div className="px-5">
         See{' '}
         <Link
-          to={`/reports/run?report=top-praise&startDate=${date2}&endDate=${date3}`}
+          to={`/reports/run?manifestUrl=https%3A%2F%2Fraw.githubusercontent.com%2Fgivepraise%2Freports%2Fmain%2Freports%2Ftop-praise%2Fmanifest.json&startDate=${date2}&endDate=${date3}`}
         >
           full report
         </Link>

From b3ce4ce2254be53a0793bf088d3e4c3648532cc0 Mon Sep 17 00:00:00 2001
From: kristoferlund <kristofer@fmckl.se>
Date: Wed, 2 Aug 2023 09:13:36 +0200
Subject: [PATCH 7/7] Fix report margins

---
 .../pages/Reports/components/presentations/ReportsTable.tsx   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/packages/frontend/src/pages/Reports/components/presentations/ReportsTable.tsx b/packages/frontend/src/pages/Reports/components/presentations/ReportsTable.tsx
index 074095599..143a3f0e6 100644
--- a/packages/frontend/src/pages/Reports/components/presentations/ReportsTable.tsx
+++ b/packages/frontend/src/pages/Reports/components/presentations/ReportsTable.tsx
@@ -14,7 +14,7 @@ export const ReportsTable = ({ data }: ReportsTableProps): JSX.Element => {
       Object.keys(data[0]).map((key) => ({
         Header: key,
         accessor: key,
-        className: 'pl-5 text-left',
+        className: 'px-5 text-left',
       })),
     [data]
   );
@@ -41,7 +41,7 @@ export const ReportsTable = ({ data }: ReportsTableProps): JSX.Element => {
             const { key, ...restHeaderGroupProps } =
               headerGroup.getHeaderGroupProps();
             return (
-              <tr className="px-5" key={key} {...restHeaderGroupProps}>
+              <tr key={key} {...restHeaderGroupProps}>
                 {headerGroup.headers.map((column) => {
                   const { key, ...restColumn } = column.getHeaderProps();
                   // eslint-disable-next-line @typescript-eslint/no-explicit-any