Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smart signature verifiers #1

Closed
joe-p opened this issue May 4, 2024 · 4 comments
Closed

smart signature verifiers #1

joe-p opened this issue May 4, 2024 · 4 comments

Comments

@joe-p
Copy link

joe-p commented May 4, 2024

I saw you were interested in making a smart sig verifier. Doing this in conjunction with a stateful app should (I haven't looked to deeply into how exactly it's implemented here) be relatively straightforward since we can read app args from an lsig and the app can verify which lsig approved a transaction.

In this PR you can see how I took the logic from the app and put it in an lsig, then had each verify each other.

@giuliop
Copy link
Owner

giuliop commented May 4, 2024

Yes, that was the approach I had in mind. The verifier is stateless, it simply processes its inputs and either succeeds or fails, so an lsig is perfectly suitable.

Unfortunately the verifier teal program is over 3KB in size and the maximum limit is 1KB for lsigs. I think I could split the verifier in two lsigs, but that's still over the limit.

I am planning to add this comment and elaborate more on the AVM limits as a comment to your other PR here, later today

@joe-p
Copy link
Author

joe-p commented May 4, 2024

There are two ways we can reduce program size

  1. Optimize for size over opcode budget during compilation.

For example

gamma_pre = sha256(b'gamma' + VK_S1_fs + VK_S2_fs + VK_S3_fs + VK_QL_fs
    			+ VK_QR_fs + VK_QM_fs + VK_QO_fs + VK_QK_fs + public_inputs_bytes

Results in a byte opcode that is nearly 800 bytes alone because all of the concatenation is done by the puya compiler. Instead we want it use the constant block which would reduce the usage of each repeated constant in the expression to 1 or 2 bytes.

  1. Offload constants in an approval program

An lsig can read the approval program of a create/update app call, so if we can offload the storage of large constants in an app (most easily done by DeleteApplication on appId 0). The hash of the approval program would be verified by the lsig and then the lsig can load constants directly from the approval program.

I am planning to add this comment and elaborate more on the AVM limits as a comment to your other PR algorand/go-algorand#5943, later today

As currently implemented, the limit would still be 700*256 per group. I think there are arguments to increase the max program size for lsigs though. I imagine we could set the limit per group (ie. you get 16kb of total lsig size per group) or increase it to ~4kb since you can already do this approval program hack for an average of ~4kb per txn.

@cusma
Copy link

cusma commented Nov 14, 2024

@giuliop I think this could be addressed now that algorand/go-algorand#6057 is merged.

@giuliop
Copy link
Owner

giuliop commented Nov 19, 2024

@giuliop I think this could be addressed now that algorand/go-algorand#6057 is merged.

Yes, will close it now

@giuliop giuliop closed this as completed Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants