Logging

[TwP]

We need to add some logging to the Client class. For each request the client makes, we should output a detailed debug message to a logger of some sort. I really like how Tire does it; logging a curl command that you can copy/paste and use directly. Also, outputting the status code of the response would be good, too ...

[200] curl -XGET 'http://localhost:9200/index/_search' -d '...'

Not sure how to handle large bodies and what not. And I don't think we need to log responses.

cc @github/search

[wfarr]

IMO, http requests with bodies should be a level of logging but likely not the default.

As far as logging request bodies goes, strip new lines and compress multiple spaces into a single space.

On Sat, Apr 20, 2013 at 6:20 PM, Tim Pease [email protected]
wrote:

We need to add some logging to the Client class. For each request the client makes, we should output a detailed debug message to a logger of some sort. I really like how Tire does it; logging a curl command that you can copy/paste and use directly. Also, outputting the status code of the response would be good, too ...

[200] curl -XGET 'http://localhost:9200/index/_search' -d '...'

Not sure how to handle large bodies and what not. And I don't think we need to log responses.

cc @github/search

Reply to this email directly or view it on GitHub:
#5

[grantr]

Maybe the client can take a :verbose level or :trace => true option that increases the logging level to include requests and responses?

[grantr]

We can't require activesupport for the low level client, but at a higher level we should use ActiveSupport::Notifications and a LogSubscriber.

[wfarr]

I'd much prefer to keep it in UNIX convention and offer info, error, debug, etc log levels.

On Mon, Apr 22, 2013 at 11:05 AM, Grant Rodgers [email protected]
wrote:

Maybe the client can take a :verbose level or :trace => true option that increases the logging level to include requests and responses?

Reply to this email directly or view it on GitHub:
#5 (comment)

[grantr]

Picking this back up.

@TwP do you like the way tire has a module-level logger instance? Should we add Elastomer.logger? Since you are well versed in all things logging I figure you'll probably know best how to add lightweight logging to a library.

[TwP]

Given ∞ time, I would much rather use https://github.com/TwP/polylog

The idea behind polylog is that each library requests a logging instance from Polylog, and the application then configures Polylog to hand out the type of logger that it wants to use. So you only need to configure a logger in one location. Every library then grabs that logger and uses it.

This is akin to SLF4J, but with a much more pronounceable name.