Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a section for the Important alert type to the style guide #35875

Merged
merged 6 commits into from
Jan 10, 2025

Conversation

Michael21107
Copy link
Contributor

Why:

Closes:
#35860

What's being changed (if available, include any code snippets, screenshots, or gifs):

Adds the fifth alert type, Important, to the style guide.

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require a SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing.

and an example rendering
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
contributing/style-guide-and-content-model/style-guide.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@Michael21107 Michael21107 marked this pull request as ready for review January 9, 2025 17:05
@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team contributing docs Content related to our contributing docs waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Jan 9, 2025
@nguyenalex836
Copy link
Contributor

@Michael21107 Thanks so much for opening this PR! I'll get this triaged for review, and as mentioned earlier, have the team provide suggestions regarding the alert type description 💛

@mchammer01 mchammer01 self-assigned this Jan 10, 2025
mchammer01
mchammer01 previously approved these changes Jan 10, 2025
Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Michael21107 - thanks for fixing this omission ✨
I made two suggestions that I'm going to apply.

Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@mchammer01 mchammer01 enabled auto-merge January 10, 2025 09:31
@mchammer01 mchammer01 added this pull request to the merge queue Jan 10, 2025
Merged via the queue into github:main with commit 5c9d8bc Jan 10, 2025
45 checks passed
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team contributing docs Content related to our contributing docs waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants