Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong alert header #35519

Open
1 task done
akordowski opened this issue Dec 2, 2024 · 3 comments · May be fixed by #35545
Open
1 task done

Wrong alert header #35519

akordowski opened this issue Dec 2, 2024 · 3 comments · May be fixed by #35545
Labels
content This issue or pull request belongs to the Docs Content team organizations Content related to organizations

Comments

@akordowski
Copy link
Contributor

akordowski commented Dec 2, 2024 •
edited
Loading

Code of Conduct

What article on docs.github.com is affected?

About OAuth app access restrictions

What part(s) of the article would you like to see updated?

The following alert should be rather a note (or maybe even a warning) then a tip.

grafik

Additional information

I could provide a PR with a fix.
@akordowski akordowski added the content This issue or pull request belongs to the Docs Content team label Dec 2, 2024
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Dec 2, 2024
@nguyenalex836
Copy link
Contributor

@akordowski Agreed 💛 feel free to open a PR when you have the time!

@nguyenalex836 nguyenalex836 added organizations Content related to organizations and removed triage Do not begin working on this issue until triaged by the team labels Dec 2, 2024
@akordowski
Copy link
Contributor Author

@nguyenalex836 I think a warning is more appropriate here (then a note) because of the can also access the organization's private resources statement. What do you think?

@nguyenalex836
Copy link
Contributor

@akordowski You're spot on - I meant to add that to my last reply, but looks like I left that out. Appreciate you doing this update! 💛

@akordowski akordowski linked a pull request Dec 4, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team organizations Content related to organizations
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix alert header akordowski/github-docs
2 participants
@akordowski @nguyenalex836