Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to PreCommit #29

Open
Gupta-Anubhav12 opened this issue Jul 7, 2021 · 3 comments
Open

Improvements to PreCommit #29

Gupta-Anubhav12 opened this issue Jul 7, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@Gupta-Anubhav12
Copy link
Member

Can we add Mypy Precommit for static type checking ,
pydocstyle for numpy style documentation
@samanyougarg
Copy link
Member

We already have a mypy config in the root folder but earlier we had decided to remove it from the pre-commit as it was giving a lot of errors at that time.
We can re-enable it now since most of the work on the core code has been done.

@samanyougarg samanyougarg added the enhancement New feature or request label Jul 8, 2021
@samanyougarg
Copy link
Member

@all-contributors please add @Gupta-Anubhav12 for code

@allcontributors allcontributors bot mentioned this issue Jul 8, 2021
Merged
@allcontributors
Copy link
Contributor

@samanyougarg

I've put up a pull request to add @Gupta-Anubhav12! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samanyougarg @Gupta-Anubhav12