From 88236f7bd23a5462febafc732689fedc3f5e7b5c Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Tue, 1 Nov 2022 09:08:36 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- eefolium/common.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/eefolium/common.py b/eefolium/common.py index cf3a71a..75d2ad6 100644 --- a/eefolium/common.py +++ b/eefolium/common.py @@ -463,7 +463,26 @@ def download_from_url(url, out_file_name=None, out_dir='.', unzip=True): if '.tar' in out_file_name: print("Unzipping {} ...".format(out_file_name)) with tarfile.open(out_file_path, "r") as tar_ref: - tar_ref.extractall(out_dir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar_ref, out_dir) final_path = os.path.join(os.path.abspath( out_dir), out_file_name.replace('.tart', ''))