highlight on yank issues

[Konfekt]

I have no luck exiting visual mode with https://github.com/girishji/vimbits/blob/04e47fba16e048b9b1a817ce1a9ef5b6a11e9f6c/autoload/vimbits/highlightonyank.vim :
with the legacy function, when escaping (= hitting <esc>) visual mode the penultimate visual selection becomes highlighted, whereas with the more recent one the whole buffer.
There are also error messages about invalid columns and line numbers every once in a while.

I did not succeed tracing back the underlying issues and reproduce, just leaving it for reference.

[girishji]

Few things to help debug: 1) Inside catch clause print the exception (echom v:exception). 2) Set in_visual = false and check if it makes any difference. 3) Also, good to check if <esc> is mapped.

[Konfekt]

Thanks for the pointers, regarding 3) that was my first reaction, but it's pristine