Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zarr sink channel window memory use #1706

Open
manthey opened this issue Oct 28, 2024 · 0 comments
Open

Zarr sink channel window memory use #1706

manthey opened this issue Oct 28, 2024 · 0 comments

Comments

@manthey
Copy link
Member

manthey commented Oct 28, 2024

PR #1705 comments out computing the zarr channel "window" metadata as part of the sink. The existing code can use arbitrarily large amounts of memory as it loads an entire channel and computes np.min and np.max. In a large (real customer use case) dataset, this was trying to load ~200 GB per channel, which was causing an OOM kill.

Since this was a work-interrupting bug, the PR just comments out the code so a release could be made. If this should be computed, it either needs to be collected as we add tiles (tricky since overwriting pixels can cause the min and max to contract) or we need to use a tile and frame iterator to walk the data in chunks.

large_image doesn't use these "window" values anywhere; we could also delete the code or make it an option (and the option would need to use a tile iterator).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant