Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make spglib version check more robust #103

Open
giovannipizzi opened this issue Jul 1, 2024 · 3 comments · May be fixed by #107
Open

Make spglib version check more robust #103

giovannipizzi opened this issue Jul 1, 2024 · 3 comments · May be fixed by #107
Assignees

Comments

@giovannipizzi
Copy link
Owner

See discussion and comment in spglib/spglib#478

@giovannipizzi giovannipizzi self-assigned this Jul 1, 2024
@t-reents t-reents linked a pull request Nov 11, 2024 that will close this issue
@t-reents t-reents linked a pull request Nov 11, 2024 that will close this issue
@DanielYang59
Copy link

I'm also seeing this error installing from a dev build of spglib, thanks for catching this:

>>> print(spglib.__version__)
2.5.1.dev28+gf0db532
        try:
>           version_pieces = [int(_) for _ in version.split(".")]
E           ValueError: invalid literal for int() with base 10: 'dev28+gf0db532'

@t-reents
Copy link
Collaborator

Hi @DanielYang59!

Thanks for the report. I'll do a new release including a more robust version check and further changes early January. For now, you could use my PR branch #107 and do a rebase. I just tested it and you shouldn't get that error anymore.

@DanielYang59
Copy link

Hi thanks for your quick response and the fix, in fact I'm not really using the dev build in production, just trying to provide some info in case it's helpful :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants