Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nextcloud 28.x Compatibility. #105

Closed
roliverio opened this issue Dec 12, 2023 · 24 comments
Closed

Add Nextcloud 28.x Compatibility. #105

roliverio opened this issue Dec 12, 2023 · 24 comments
Assignees

Comments

@roliverio
Copy link

Quick issue to update the app to support Nextcloud 28.x onwards. Thanks!

@gino0631 gino0631 self-assigned this Dec 12, 2023
@gino0631
Copy link
Owner

@roliverio thanks for the reminder.

@RainerEmrich
Copy link

@roliverio thanks for the reminder.
ping

@Chrispikaan
Copy link

Is there an update on this? I really like this app, but it isn't working right now.

@gino0631
Copy link
Owner

gino0631 commented Jan 8, 2024

Apologies for the delay, but this time it will take longer as there are more changes in the Nextcloud itself.

@galandilias
Copy link

Any progress on this one?

@gino0631
Copy link
Owner

gino0631 commented Feb 8, 2024

@galandilias thanks for the ping. Unfortunately, still no, though I hope to make it this month.

@plaes
Copy link

plaes commented Feb 12, 2024

@galandilias thanks for the ping. Unfortunately, still no, though I hope to make it this month.

Firstly, the real cause for this issue: OCA.Files.FileList was a private API that app developers should not have relied upon.

And secondly, NextCloud frontend has been gradually migrating to Vue for rendering.
Best "resource" I could find about this was this issue: nextcloud/server#20020

@gino0631
Copy link
Owner

@plaes the first version of your message named the reasons correctly.

Firstly, the real cause for this issue: OCA.Files.FileList was a private API that app developers should not have relied upon.

This has nothing to do with the issue.

As for the Vue, yes, the support for the non-Vue sidebar apps was silently removed, which is the biggest problem for now.

@immanuelfodor
Copy link

I regularly get these log lines over and over, this probably has to do with compatibility:
"message":"Could not boot metadata: Call to undefined method OC\\Server::getEventDispatcher()"

@gino0631
Copy link
Owner

@immanuelfodor yes, this was already reported in #106

@PeterLue
Copy link

The same error message was displayed in another project (OCCWEB). The solution here was the call
OC::$server->getEventDispatcher(),
through
OC::$server->get(\OCP\EventDispatcher\IEventDispatcher::class),
to replace. Just for info.

@gino0631
Copy link
Owner

@PeterLue yes, but that is not enough for compatibility with NC 28

@nooblag
Copy link

nooblag commented Feb 29, 2024

I regularly get these log lines over and over, this probably has to do with compatibility: "message":"Could not boot metadata: Call to undefined method OC\\Server::getEventDispatcher()"

Hi there, thanks for a great app. Just reporting I get lots of these in the logs with Nextcloud 28. Reading this thread, sounds like work is still ongoing for an update, so thank you. 😄

@gino0631
Copy link
Owner

@nooblag yes, you can try disabling the app meanwhile

@aliyasiny65
Copy link

Hello, when will nextcloud 28 compatibility come?

@Ch3ck3rM0n
Copy link

I regularly get these log lines over and over, this probably has to do with compatibility: "message":"Could not boot metadata: Call to undefined method OC\\Server::getEventDispatcher()"

Hi there, thanks for a great app. Just reporting I get lots of these in the logs with Nextcloud 28. Reading this thread, sounds like work is still ongoing for an update, so thank you. 😄

I having the same output in the logs/issue with the app. I am also waiting for an update :-/

@SKB-CGN
Copy link

SKB-CGN commented Mar 17, 2024

In the meanwhile you can use the Memories App, to display the metadata.

@yeupou
Copy link

yeupou commented Mar 28, 2024

Hi there,

I noticed no problem with the metadata app on NC 28 since a few month, besides the massive log noise output.

Is it possible to get the app uploaded with PeterLue fix, in the meantime?

Thanks.

@roliverio
Copy link
Author

I've just received notice of the close-by release of NC 29.xx and this app hasn't had updates for v28. Do you plan on still maintaining it?. Thanks for any update.

@gino0631
Copy link
Owner

@roliverio thanks for the ping. No, this app is not abandoned. As for Nextcloud, I'm seriously disappointed, and personally decided just not to upgrade, as it only gets worse with every new release (though I haven't found any suitable replacement so far). The works on the app depend on free time I have, and therefore don't go smoothly sometimes (especially when the workload is higher due to the nature of changes in Nextcloud).

@gino0631
Copy link
Owner

@yeupou are you sure the app is working for you on NC 28?

@roliverio
Copy link
Author

@gino0631 I understand and i don't blame you at all. I do love your work, and i appreciate the existence of this app, however, i can't deny that i'm blocked from upgrading because i can't use it on newer versions. So i just wanted to know if you would continue working on it. Thanks again.

@IndrekHaav
Copy link

@yeupou are you sure the app is working for you on NC 28?

I set up a NC28 dev environment and made the change suggested by @PeterLue above, but the app isn't working, the Metadata tab doesn't show up in the sidebar. Looks like front-end changes are needed as well, but I'm not familiar enough with Nextcloud app development to take a crack at it.

FWIW, Nextcloud 28 API changes are documented here: https://docs.nextcloud.com/server/28/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_28.html

@jgrete
Copy link

jgrete commented May 8, 2024

Oh yes, pleeease, add 28.x compatibility. Without I will not update to NC 28.x.x because I love your app!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests