From 2cf81666ed4ee4a929cd2e157da63da91d84ff81 Mon Sep 17 00:00:00 2001 From: Igor Date: Mon, 20 Jan 2025 13:29:18 +0100 Subject: [PATCH] fix(GiniBankSDK): PR comment fixes --- .../GiniBankAPILibrary/Documents/Core/GiniBankAPI.swift | 5 ++++- .../NetworkingScreenApiCoordinatorTests.swift | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/BankAPILibrary/GiniBankAPILibrary/Sources/GiniBankAPILibrary/Documents/Core/GiniBankAPI.swift b/BankAPILibrary/GiniBankAPILibrary/Sources/GiniBankAPILibrary/Documents/Core/GiniBankAPI.swift index e2edb69b5..5d3444d99 100644 --- a/BankAPILibrary/GiniBankAPILibrary/Sources/GiniBankAPILibrary/Documents/Core/GiniBankAPI.swift +++ b/BankAPILibrary/GiniBankAPILibrary/Sources/GiniBankAPILibrary/Documents/Core/GiniBankAPI.swift @@ -7,7 +7,10 @@ import Foundation -// should only be used in tests +/** +Sets the default error logger. It is only used when giniErrorLoggerIsOn is true. +- note: Internal usage only. +**/ var _GINIBANKAPILIBRARY_DISABLE_KEYCHAIN_PRECONDITION_FAILURE: Bool = false /// The Gini Bank API Library diff --git a/BankSDK/GiniBankSDK/Tests/GiniBankSDKTests/NetworkingScreenApiCoordinatorTests.swift b/BankSDK/GiniBankSDK/Tests/GiniBankSDKTests/NetworkingScreenApiCoordinatorTests.swift index 58fc9a771..6261bdf73 100644 --- a/BankSDK/GiniBankSDK/Tests/GiniBankSDKTests/NetworkingScreenApiCoordinatorTests.swift +++ b/BankSDK/GiniBankSDK/Tests/GiniBankSDKTests/NetworkingScreenApiCoordinatorTests.swift @@ -66,7 +66,7 @@ final class NetworkingScreenApiCoordinatorTests: XCTestCase { trackingDelegate = MockTrackingDelegate() } - func testSDKClose() throws { + func testCloseSDK() throws { let (coordinator, _) = try makeCoordinatorAndService(fromViewController: true) // so the sdk would start XCTAssertEqual(GiniBankNetworkingScreenApiCoordinator.currentCoordinator, coordinator, "The coordinator should be the same")