Skip to content
This repository has been archived by the owner on Apr 12, 2022. It is now read-only.

Add support for passing node-fetch options #34

Open
wintercounter opened this issue Oct 15, 2021 · 3 comments
Open

Add support for passing node-fetch options #34

wintercounter opened this issue Oct 15, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@wintercounter
Copy link

The Deepl API after 10-15 translations hangs me for a while, sometimes even 5 minutes... I'd like to use AbortController and implement a retry/timeout feature for myself. (Or it could be part of the client as well).

@gillescoolen gillescoolen self-assigned this Oct 15, 2021
@gillescoolen gillescoolen added the enhancement New feature or request label Oct 15, 2021
@gillescoolen
Copy link
Owner

Understandable. I've got a busy weekend, so I can try and implement it next week. If you've got the time, PR's are always welcome :)

@wintercounter
Copy link
Author

Which solution ur interested in? Only passing options or implementing timeout/retry? Anyway, for myself I think I won't use it, because it'll still count my character limit even for the "failed" requests.

@gillescoolen
Copy link
Owner

I think passing the options would be the better solution, as implementing a timeout or retry system might not be an option for everyone using the library.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants