Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace OrderedDict with the built-in dict #520

Closed
nikteliy opened this issue May 28, 2024 · 2 comments
Closed

Replace OrderedDict with the built-in dict #520

nikteliy opened this issue May 28, 2024 · 2 comments
Milestone
2.0

Comments

@nikteliy
Copy link
Contributor

Since Python 3.7, the built-in dict type maintains insertion order by default. Do we need to continue using OrderedDict?
Unless we have a specific reason, I suggest that we replace OrderedDict with the built-in dict.
@lupaulus
Copy link
Contributor

+1

@gijzelaerr
Copy link
Owner

implemented in this PR #524

@gijzelaerr gijzelaerr mentioned this issue Jul 4, 2024
Merged
@gijzelaerr gijzelaerr added this to the 2.0 milestone Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
3 participants
@gijzelaerr @lupaulus @nikteliy