Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused CLI parameters or implement functionality #8

Open
dzhoshkun opened this issue Jul 19, 2016 · 1 comment
Open

Remove unused CLI parameters or implement functionality #8

dzhoshkun opened this issue Jul 19, 2016 · 1 comment
Assignees
@dzhoshkun

Comments

@dzhoshkun
Copy link
Contributor

dzhoshkun commented Jul 19, 2016 •
edited
Loading

  1. --calibration-file does not seem to be used any more
  2. the rows and cols specification of --pattern-specs seem to be too much as well, are these being used at all ?
dzhoshkun pushed a commit that referenced this issue Aug 1, 2016
Issue #5: added meaningful parameter meta variables for all but the c…
bb2abcb 
…alibration file parameter, which might be removed in #8
@dzhoshkun dzhoshkun added this to the 17.8 release milestone Jul 24, 2017
@dzhoshkun dzhoshkun removed this from the 17.8 release milestone Feb 14, 2018
@dzhoshkun dzhoshkun self-assigned this Feb 14, 2018
@dzhoshkun dzhoshkun changed the title Remove unused parameters or implement corresponding functionality Remove unused CLI parameters Apr 19, 2018
@dzhoshkun dzhoshkun changed the title Remove unused CLI parameters Remove unused CLI parameters or implement functionality Apr 19, 2018
dzhoshkun pushed a commit that referenced this issue Apr 19, 2018
Issue #8: added conditional statement stub taking into account unused…
bd16d05 
… calibration file parameter of Calibrator
dzhoshkun pushed a commit that referenced this issue Apr 19, 2018
Issue #8: added utility function for extracting numbers from YML-enco…
8e4bbde 
…ded numpy array
dzhoshkun pushed a commit that referenced this issue Apr 19, 2018
Issue #8: support for loading saved calibration parameters into Calib…
6d8b8fc 
…rator
dzhoshkun pushed a commit that referenced this issue Apr 19, 2018
Issue #8: removed reset at the end of Calibrator constructor
b83a068
@dzhoshkun
Copy link
Contributor Author

  • ROI needs to be respected when loading a calibration file, as it changes the camera center.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dzhoshkun dzhoshkun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dzhoshkun