Skip to content
This repository has been archived by the owner on Jun 14, 2020. It is now read-only.

Remove the zero star constraint? #127

Open
dufferzafar opened this issue Sep 3, 2018 · 11 comments
Open

Remove the zero star constraint? #127

dufferzafar opened this issue Sep 3, 2018 · 11 comments
Labels
enhancement New feature or request

Comments

@dufferzafar
Copy link

I never star my own repositories, and know a few people who don't either.

So a bunch of them may have no stars at all, but I'd still like to have them displayed.

@lourot
Copy link
Member

lourot commented Sep 3, 2018

Indeed there is room for improvement here. The constraint came in because some users like to fork many repositories without actually contributing to these projects and their profiles would otherwise end up being unnecessarily resource-consuming to refresh every day. So early in the daily refreshing-process we skip repositories with no stars.

One quick improvement I see would be to have this constraint only on forks, not on original repos. This could be even improved later but this would be a very easy move for now. What do you think?

@lourot lourot added the enhancement New feature or request label Sep 3, 2018
@dufferzafar
Copy link
Author

Yeah, that does seem right.

But in general I feel there is not one-size-fits-all solution here.

Everyone has their own ways of arranging forks etc. - some people create an entirely separate account just for forking, like: https://github.com/evandroforks

Maybe there could be some user specific config when they're creating a ghuser profile.

So, they would check boxes like: Import Zero-star forks etc.

@lourot
Copy link
Member

lourot commented Sep 3, 2018

👍 indeed this could be in the user settings

@ocdtrekkie
Copy link

I have found that https://github.com/ghuser-io/ghuser.io#some-of-my-repos-are-not-showing-up-on-my-profile-why doesn't appear to be accurate.

Repos I opened, and then starred, have still not shown up on my profile after refreshes. Meanwhile, I do have a zero-star repo that appears on my profile.

@brillout
Copy link
Collaborator

brillout commented Jan 4, 2019

@ocdtrekkie same here
@AurelienLourot E.g. https://github.com/brillout/wildcard-api is not on my ghuser.io's profile

@ocdtrekkie
Copy link

Starred repos that are not on my ghuser.io profile:
https://github.com/ocdtrekkie/GamesLib
https://github.com/ocdtrekkie/dust-gents.com

@lourot
Copy link
Member

lourot commented Jan 10, 2019

@brillout regarding a chat we had a few days ago where we suspected the unofficial API crawler to be the root cause: it's not the case, it successfully discovered wildcard-api as you can see in https://s3.amazonaws.com/ghuser/data/users/brillout.json

So the bug must be in my code later in the data pipeline where I crawl the official API and perform calculations and populate the rest of the DB. (It might even be in the front-end but it's more likely to be in my scripts I'd say)

I'm working on it :) I expect to have this fixed somewhere this week-end.

@lourot lourot self-assigned this Jan 10, 2019
@brillout
Copy link
Collaborator

Ok cool:)

@lourot
Copy link
Member

lourot commented Jan 14, 2019

Indeed I found it, it's a nasty mistake from me leading to this effect: once I crawl a repo with zero stars, I never crawl it again :( I have a fix ready and I'll now start the crawler with that fix and hopefully these missing repos will pop up on your profiles tomorrow.

@lourot
Copy link
Member

lourot commented Jan 15, 2019

brillout/wildcard-api and ocdtrekkie/GamesLib popped up, but not ocdtrekkie/dust-gents.com. I'll look into it.

@lourot
Copy link
Member

lourot commented Jan 16, 2019

ocdtrekkie/dust-gents.com is now fixed as well :)

(I'm keeping this issue open for the original topic, which was about removing the zero star constraint.)

@lourot lourot removed their assignment Jan 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants