Skip to content
This repository has been archived by the owner on Jul 21, 2021. It is now read-only.

Need to figure out which concrete impl to use for I2C #40

Closed
Arke64 opened this issue May 4, 2018 · 11 comments
Closed

Need to figure out which concrete impl to use for I2C #40

Arke64 opened this issue May 4, 2018 · 11 comments
Assignees

Comments

@Arke64
Copy link

Arke64 commented May 4, 2018

codal::i2c is just a base class.

@Arke64 Arke64 self-assigned this May 4, 2018
@VictorDuma-zz
Copy link

Can we use other than _mbed::I2C?

@Arke64
Copy link
Author

Arke64 commented May 4, 2018

It's being looked into, there's nothing for us to do here at the moment

@VictorDuma-zz
Copy link

yes. I added missed functions and locally codal::I2C works. lancaster-university/codal-core#26

@pelikhan
Copy link

pelikhan commented May 8, 2018

@VictorDuma @Arke64 could you look into creating a PR for codal-mbedos? What is the status here?

@Arke64
Copy link
Author

Arke64 commented May 8, 2018

@pelikhan do you mean a PR to update lancaster-university/codal-mbedos I2C to match what was done in codal-mbed, as mentnioed in lancaster-university/codal-core#26?

@pelikhan
Copy link

pelikhan commented May 8, 2018

Yes similar to the PR that James mentionned.

@Arke64
Copy link
Author

Arke64 commented May 10, 2018

We'll take a look and see what we can do

@Arke64
Copy link
Author

Arke64 commented May 10, 2018

@Arke64
Copy link
Author

Arke64 commented May 10, 2018

Done in above PR, will keep using codal::_mbed::I2C

@Arke64 Arke64 closed this as completed May 10, 2018
@pelikhan
Copy link

Do you have a new tag?

@Arke64
Copy link
Author

Arke64 commented May 10, 2018

We didn't have to change anything in BrainPad, we were already using codal::_mbed::I2C. We'll get a new tag as soon as we finish the display format change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants