Skip to content
This repository has been archived by the owner on Jul 21, 2021. It is now read-only.

Clean BrainPadPin #3

Open
Arke64 opened this issue Mar 8, 2018 · 2 comments
Open

Clean BrainPadPin #3

Arke64 opened this issue Mar 8, 2018 · 2 comments
Assignees
@Palomino34

Comments

@Arke64
Copy link

Arke64 commented Mar 8, 2018

No description provided.

Arke64 pushed a commit that referenced this issue Mar 15, 2018
@greg-norris
Merge pull request #3 from ghi-electronics/greg-norris-patch-1
e67b432 
Removed unnecessary codal image header.
@Arke64
Copy link
Author

Arke64 commented Mar 22, 2018

We put pin as protected. Is the class ever derived from? If not, it should be private. Also is there a reason for it to be void*? Shouldn't it be AnalogIn* ain or similar? We also don't properly dispose of it, so we potentially leak memory.

@Arke64 Arke64 changed the title Figure out what to do with model/BrainPadPin.cpp Clean BrainPadPin Apr 18, 2018
@Arke64
Copy link
Author

Arke64 commented Apr 18, 2018

Need to keep it around since the higher layers use it for analog reading.

@Arke64 Arke64 assigned Arke64 and unassigned Arke64 Dec 3, 2018
@Arke64 Arke64 assigned Palomino34 and unassigned Arke64 Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Palomino34 Palomino34

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Arke64 @gus-ghielec @Palomino34 @VictorDuma-zz @greg-norris