Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A Kafka Support (GSI-933) #6

Merged
merged 15 commits into from
Aug 28, 2024
Merged

A Kafka Support (GSI-933) #6

merged 15 commits into from
Aug 28, 2024

Conversation

TheByronHimes
Copy link
Member

@TheByronHimes TheByronHimes commented Aug 26, 2024 •
edited
Loading

Adds a single endpoint to enable clearing topics. The functionality under the hood is almost identical to the version in the hexkit test fixture.

The endpoint is DELETE /events/, which will return a 204 in the absence of any errors. The error codes returned to the client are either 422, indicating that a topic name was invalid, or a 500, indicating any other error.

@coveralls
Copy link

coveralls commented Aug 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10591970960

Details

  • 59 of 60 (98.33%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 92.562%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/sms/ports/inbound/events_handler.py 4 5 80.0%
Totals Coverage Status
Change from base Build 10521684031: 0.6%
Covered Lines: 560
Relevant Lines: 605
💛 - Coveralls

@TheByronHimes TheByronHimes marked this pull request as ready for review August 26, 2024 13:51
mephenor
mephenor requested changes Aug 27, 2024
View reviewed changes
Copy link
Member

@mephenor mephenor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some smaller adjustements and one of the test cases has a logic problem.

tests/unit/events/__init_.py Show resolved Hide resolved
src/sms/adapters/inbound/fastapi_/routers/events.py Outdated Show resolved Hide resolved
src/sms/core/events_handler.py Outdated Show resolved Hide resolved
src/sms/core/events_handler.py Outdated Show resolved Hide resolved
tests/integration/test_events.py Outdated Show resolved Hide resolved
tests/integration/test_events.py Outdated Show resolved Hide resolved
tests/integration/test_events.py Show resolved Hide resolved
tests/unit/events/test_events_handler.py Show resolved Hide resolved
src/sms/adapters/inbound/fastapi_/routers/events.py Outdated Show resolved Hide resolved
dontseyit
dontseyit requested changes Aug 27, 2024
View reviewed changes
Copy link
Member

@dontseyit dontseyit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Thomas already made some good suggestions and I just added a little more.

src/sms/adapters/inbound/fastapi_/routers/events.py Show resolved Hide resolved
src/sms/core/events_handler.py Outdated Show resolved Hide resolved
@TheByronHimes TheByronHimes requested a review from mephenor August 28, 2024 07:14
mephenor
mephenor approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@mephenor mephenor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

@TheByronHimes TheByronHimes merged commit cb6d620 into main Aug 28, 2024
9 checks passed
@TheByronHimes TheByronHimes deleted the feature/kafka_support_GSI-933 branch August 28, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mephenor mephenor mephenor approved these changes

@dontseyit dontseyit dontseyit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TheByronHimes @coveralls @dontseyit @mephenor