Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileFormatEnum additional permissible value #138

Open
sbilge opened this issue Nov 23, 2023 · 3 comments
Open

FileFormatEnum additional permissible value #138

sbilge opened this issue Nov 23, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@sbilge
Copy link
Collaborator

sbilge commented Nov 23, 2023

Data format "PDF" is used in the metadata submission sheet of EGA synthetic dataset. But PDF is not one of the permissible values of that field. Thus, the validation fails.

I am aware that the EGA synthetic data will not live on our catalog. However, if we will get "PDF" files from the future submissions, we should add it to permissible values of FileFormatEnum. Alternatively we can use "OTHER" instead of "PDF".

@sbilge sbilge added the enhancement New feature or request label Nov 23, 2023
@sbilge sbilge assigned sbilge, mauerk and anandhi-iyappan and unassigned sbilge Nov 23, 2023
@anandhi-iyappan
Copy link
Contributor

We we will have to wait to discuss with the experts on synthetic datasets and RD (on certain fields including this) to come to a decision

@sbilge
Copy link
Collaborator Author

sbilge commented Nov 24, 2023

I see it as more related to the expected data formats, than a dataset-specific issue. Even if we do not use EGA synthetic dataset, we should answer the question if we ever expect to get PDF files and if so, how we want to handle it, e.g., either adding PDF to permissible values, or deciding that it will be represented under the "other" category.

@anandhi-iyappan
Copy link
Contributor

In that case for now, I would put it in Other unless we see there are more recurring PDF file request where we have to add it as a permissible value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants