Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why promises for hashing functions? #42

Open
pke opened this issue May 4, 2022 · 5 comments
Open

Why promises for hashing functions? #42

pke opened this issue May 4, 2022 · 5 comments

Comments

@pke
Copy link
Collaborator

pke commented May 4, 2022

I wonder why the hashing functions are all sync natively, yet return promises? Any reason for that?
@ghbutton
Copy link
Owner

ghbutton commented May 4, 2022

That is a good question, I can work on that

@pke
Copy link
Collaborator Author

pke commented May 4, 2022

Its seems using sync function have some implications
https://reactnative.dev/docs/native-modules-ios#synchronous-methods

@ghbutton
Copy link
Owner

I still think making them async is the way to go

@ghbutton
Copy link
Owner

Fixed here: #44

@ghbutton
Copy link
Owner

I invited you as a collaborator if that is ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pke @ghbutton