Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Submission doesn't check for destroyed textures #6625

Open
jimblandy opened this issue Nov 26, 2024 · 2 comments
Open

[core] Submission doesn't check for destroyed textures #6625

jimblandy opened this issue Nov 26, 2024 · 2 comments
Labels
area: validation Issues related to validation, diagnostics, and error handling type: bug Something isn't working

Comments

@jimblandy
Copy link
Member

wgpu_core::device::queue::Queue::submit calls validate_command_buffer, which checks for destroyed buffers, but it doesn't perform any analogous check on textures. Should it?

@sagudev
Copy link
Contributor

sagudev commented Nov 30, 2024

It should per spec:

If any of the following requirements are unmet, generate a validation error, invalidate each GPUCommandBuffer in commandBuffers and return.
For each of the following types of resources used by any command in any element of commandBuffers:
...
GPUTexture t
t.[[destroyed]] must be false.
...

@cwfitzgerald cwfitzgerald added type: bug Something isn't working area: validation Issues related to validation, diagnostics, and error handling labels Dec 2, 2024
@jimblandy
Copy link
Member Author

I'll mark this P1 for now, because it seems like freeing the texture too early could cause problems. But if it's not a crasher, then we can lower the priority to P2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: validation Issues related to validation, diagnostics, and error handling type: bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

3 participants