Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GLSL Memory Qualifier Storage Access parsing is probably incorrect #6601

Open
atlv24 opened this issue Nov 24, 2024 · 0 comments
Open

GLSL Memory Qualifier Storage Access parsing is probably incorrect #6601

atlv24 opened this issue Nov 24, 2024 · 0 comments
Labels
area: naga front-end lang: GLSL OpenGL Shading Language naga Shader Translator type: bug Something isn't working

Comments

@atlv24
Copy link
Contributor

atlv24 commented Nov 24, 2024

readonly and writeonly can be used simultaneously, implying that neither is allowed, but the parser seems to treat them additively:

wgpu/naga/src/front/glsl/lex.rs

Lines 88 to 89 in c22c062

"readonly" => TokenValue::MemoryQualifier(StorageAccess::LOAD),
"writeonly" => TokenValue::MemoryQualifier(StorageAccess::STORE),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: naga front-end lang: GLSL OpenGL Shading Language naga Shader Translator type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@atlv24 @teoxoy