Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builder: Make the eopkg binary configurable #111

Merged
merged 2 commits into from
Sep 21, 2024
Merged

Conversation

silkeh
Copy link
Member

@silkeh silkeh commented Sep 18, 2024

This PR supersedes #105 by making the used binaries of eopkg and ypkg configurable using the --ypkg-bin and --eopkg-bin flags. This allows for comparative tests.

Make a cosmetic tweak to eopkg install commands (which will
effectively be using eopkg.bin when the PR above lands) so the -y flag
is set before the -c flag when installing components.

Signed-off-by: Rune Morling <[email protected]>
This allows for testing and comparing builds between various implementations of the binaries.
Copy link
Contributor

@ermo ermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment nit to help future us, otherwise looks nice.

builder/eopkg.go Show resolved Hide resolved
@ermo ermo added the enhancement New feature or request label Sep 19, 2024
@ermo ermo merged commit 39c0bf5 into master Sep 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants